Improve Windows desktop integration - #914
Draft
Lododizzle wants to merge 4 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/healthendpoint in addition to console outputvoicebox-mcpshim in the local Windows build recipeWhy
The Windows package could be built and run natively, but it lacked normal background-app behavior and visible lifecycle controls for its bundled server.
Two packaging failures also affected local Windows builds:
--noconsole, which redirects stdout/stderr to NUL, while the Tauri launcher previously waited for a Uvicorn log line as its only readiness signal. Production startup could therefore time out even when the server started.PATH. A third-party LLVM installation could shadow the current Windows VC++ runtime and bundle an oldMSVCP140.dll, causingvoicebox-server.exeto crash with0xc0000005immediately after extraction.The local build recipe also omitted a required external binary, while Bun workspace symlinks can be unavailable on Windows systems without symlink support.
Impact
Windows users get a self-contained desktop workflow: install the app, leave it running in the notification area, and control the local Voicebox backend from the UI. Server startup no longer depends on unavailable console output, and local builds prefer the current Windows VC++ runtime over unrelated toolchain copies.
Existing isolated Bun installs remain the preferred dependency path; the hoisted path is only a fallback.
Validation
bun run typecheckbunx biome checkon the changed TypeScript/JSON files (one pre-existing exhaustive-deps warning)cargo check --manifest-path tauri/src-tauri/Cargo.toml --lockedruff check backend/build_binary.pyruff format --check backend/build_binary.py/healthresponse on an isolated port in 8 seconds and was stopped immediately afterwardMSVCP140.dll,MSVCP140_1.dll, andMSVCP140_ATOMIC_WAIT.dllfromC:\Windows\System32No model inference or GPU tests were run. Local updater artifact signing was not attempted because the maintainer private signing key is not available in a contributor checkout.