fix(audio): make macOS keep-alive configurable - #962
Open
kevincommits wants to merge 2 commits into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (14)
📝 WalkthroughWalkthroughThe PR adds a persisted ChangesAudio keep-alive preference
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AudioKeepAlivewhen disabled, so its existing cleanup pauses the loop, clears the media source, and releases the blob URL/CoreAudio output.Why
The silent looping element added for #41 prevents WKWebView's audio session from becoming unusable after switching apps, but on some Macs it keeps the physical speaker output active and causes audible idle hiss or interference. Users affected by that tradeoff currently have to quit Voicebox to release the speaker.
This preserves the compatibility workaround for existing users while giving affected users a persistent, immediate way to disable it.
Closes #911.
Verification
cd app && bun test tests/audioKeepAlivePolicy.test.ts— 3 passedcd app && bun run typecheck— passedcd app && bun run build— passedbun run ci— app/web type-checks and web production build passedSummary by CodeRabbit
New Features
Bug Fixes