fix(rclonecli): improve vfs cache refresh/forget logic and parameter types#649
Merged
Merged
Conversation
…lth classification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The rclone VFS cache refresh/forget calls had two issues:
stringwhere the rclone RC API expects other types, causing silent failures or ignored cache refreshesvfs/refreshin cases wherevfs/forgetis the correct operation (and vice versa), meaning newly imported files were sometimes not appearing in the mount, or stale entries were not being evictedFix
vfs/refreshandvfs/forgetRC callsrefresh(populate new dir entries) vsforget(evict stale cache) based on the operation contextImpact
Newly imported files now reliably appear under the rclone mount without requiring manual cache refreshes or container restarts.