Remove ARR Force Stop + quota canisters UI, settings collapse, chart tooltip fixes#663
Merged
Merged
Conversation
…hover polish - remove Liquid Quota Canisters panel and vial CSS (backend quota APIs kept) - remove ARR Force Stop end to end (routes, worker pause flag, UI); queue auto-cleanup and failure breakers untouched - collapse Failure Masking and Segment Cache settings when disabled - normalize stat-card hover highlights; drop Total Errors bounce
- tint pie tooltip text with hovered slice color - make area-chart hover tooltip fully opaque so the legend doesn't bleed through
- zIndex on the recharts tooltip wrapper (transform creates a stacking context, so inner z-50 never lifted it above the legend - Total row was painted over) - disable tooltip position animation (pie text no longer slides)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up cleanup on top of #659: removes two features that didn't earn their complexity, brings a couple of config sections in line with the rest of the settings UX, and fixes chart tooltip papercuts on the Health page.
Changes
Removed: ARR Force Stop
Strips the Force Stop brake end to end — API routes (
GET/POST/DELETE /api/arrs/pause), the worker's in-memory pause flag and gates, theService.SetArrsPaused/IsArrsPausedwrappers, the health-worker defer checks (repairOutcomePaused), and the Queue page Cleanup-dropdown UI.Queue auto-cleanup and the failure circuit breakers are untouched — the shared failure tracker, breaker bump/reset,
CleanupStuckQueue, the importer-side breaker (HandleImportFailure), and the indexer history sync all keep working exactly as in #659. Tests updated accordingly (removed the Force Stop gate test + mock method).Removed: Liquid Quota Canisters panel
Drops the
ProviderQuotacomponent and itsvial-*CSS /liquid-wavekeyframes from the Provider Health page. The backend quota tracking andreset-quotaendpoint are retained — they're shared with the Dashboard and the provider config section.Settings: collapse disabled sections
Failure Masking and Segment Cache sections now collapse their dependent fields when toggled off (same
fade-in slide-in-from-top-2 animate-inreveal pattern as the SABnzbd and Arrs sections), instead of graying them out.Health page polish
opacity-45 → group-hover:opacity-85animate-bounceon the Total Errors iconzIndexon the recharts tooltip wrapper (it's positioned withtransform, which creates a stacking context, so the legend painted over the tooltip and clipped the Total row), made the tooltip background fully opaque, disabled tooltip position animation (pie tooltip no longer slides around), and tinted the pie tooltip text with the hovered slice colorTesting
go build ./...,go vet, andgo test ./internal/arrs/... ./internal/health/...passbun run checkandbun run buildpass