Repository navigation
Conversation
Ousret
enabled auto-merge
October 20, 2026 05:35
Ousret
previously approved these changes
Oct 20, 2026
Ousret
added this pull request to the merge queue
Oct 20, 2026
Ousret
removed this pull request from the merge queue due to the queue being cleared
Oct 20, 2026
Ousret
approved these changes
Oct 20, 2026
Ousret
enabled auto-merge (squash)
October 20, 2026 06:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed
CharsetMatch.output()call updates the cached target encoding before encoding succeeds. Repeating the same invalid target then returnsNone, or bytes left from a previous successful target, instead of raising again.Update the target encoding only after the payload has been produced successfully. Header rewriting uses the requested local encoding, so a failed charset lookup also leaves the last valid cached output intact.
The two regressions cover empty and populated caches, repeated invalid requests, and successful UTF-8/Latin-1 outputs afterward. Both fail before the change and pass after.
Validation: project
nox -s test-3.12,nox -s lint, andnox -s coveragepass; the charset corpus result is 98.323% (469/477 files), above the session's 90% requirement. Testing used Python 3.12.13.