Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to apache#25724. This is a stacked PoC for benchmark validation and does not close an issue.
Rationale for this change
The final hash aggregation in apache#25724 moves its accumulated groups to buckets once the threshold is reached. Retaining those groups could reduce bucket input and the merge after input ends when later rows repeat the same keys. This draft tests that idea with an opt-in implementation and reproducible benchmarks. It is not proposed for merge yet.
What changes are included in this PR?
hash_aggregate_bucket_adaptiveoption. After a 65,536-row sample, probing is bypassed when fewer than 25% of rows hit the frozen keys.The local optimized synthetic benchmark found this PoC 7%–21% slower than the original bucket path in all six queries. It uses a second encoded-key index because
GroupValueshas no lookup-only API. This draft exists so the same branch can be measured on the benchmark host with real ClickBench data.Benchmark host commands
Real ClickBench Q11/Q12/Q14 and Q18/Q33/Q34, using the host's
hits.parquetand Jay's threshold of 262,144, are still needed for the decision. This local machine did not have the dataset.What is the testing strategy for this PR?
cargo fmt --all: passed.cargo clippy --all-targets --all-features -- -D warnings: passed.aggregate_bucketed/information_schemaSQL logic tests: passed.git diff --check: passed../dev/rust_lint.shcould not start because local/usr/bin/python3lacks PyYAML anduvis unavailable. These gates remain open before any merge.Are there any user-facing changes?
Only the off-by-default execution option and additional physical plan metrics. Existing behavior remains the default.