Apply conservative tooltip standard across apps - #32
Open
jbkunst wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
README.md, explicitly covering published apps and drafts.titleattributes from icon triggers to avoid the second browser tooltip.aria-labelwrapper and supportshover focus click."tooltip-bg" = "#495057".app-templateso new apps start with the same tooltip theme.Repo-wide audit
The canonical apps were reviewed conservatively. Tooltips are added only where they contribute information that is not already obvious or adequately explained in the app README/UI.
Tooltips kept or added
lorenz-attractor: sigma, rho, beta, and time step. The README shows the equations but does not interpret the controls.decision-tree: percent noise only. Depth and alpha are intentionally left without tooltips because the README already explains them.pokemon-dimensionality-reduction(Status: draft): t-SNE perplexity plus UMAP neighbors and minimum distance. The README names these parameters but does not explain their effect.Audited with no new tooltips
kmeans,kmeans-images,arma-process,roc-curve,logistic-regression,underfitting-overfitting,binary-predictions-metrics,network-structures,dimensionality-reduction, andshap-explorerwere left unchanged where controls are obvious or the existing README/UI already provides the explanation. Alternativeapp_*.Rfiles are not treated as canonical app implementations.Design rule
Apps with existing theme customizations add the same Sass variable to their existing
bs_theme()call.Scope
This PR changes only the shared guidance/template and the apps where the audit found a clear reason for contextual input help. It does not force every app to have tooltips.