Stop OSError leaks past rmtree's ignore_errors - #357
Merged
jborean93 merged 1 commit intoJun 22, 2026
Conversation
rmtree's top-level islink probe ran outside any try-except, so an OSError there bypassed ignore_errors=True. ignore_errors installs a no-op onerror, not a global suppressor, so any unguarded call reaches the caller.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #357 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 24 24
Lines 5276 5276
=======================================
Hits 5212 5212
Misses 64 64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jborean93
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rmtree's top-level islink probe ran outside any try-except, so an OSError there bypassed ignore_errors=True.
ignore_errors installs a no-op onerror, not a global suppressor, so any unguarded call reaches the caller.