refactor(mrml-core): scope the dead_code allow to the render feature - #690
Merged
Merged
Conversation
Signed-off-by: Jeremie Drouet <jeremie.drouet@gmail.com>
Contributor
|
📈 This is how your metrics evolved 📉 |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mjml/mod.rsopens with a module-wide#![allow(dead_code)]. It turns out to be covering exactly two methods,MjmlAttributes::langand::dir, which are only reachable frommjml/render.rsand so look unused whenever therenderfeature is off.Gating that impl block with
#[cfg(feature = "render")]says the same thing precisely, and lets the blanket allow go. A module-wide allow silences the lint for everything else in the file too, permanently — which is how two methods end up hiding behind a switch that covers the whole module.Verified with a clean compile under every relevant feature combination, since that is the only way this one shows up:
--no-default-features+parse+render+json+print--all-featuresTests stay at 621.