Repository navigation
fix: prevent integer divide by zero panic in AutoMerge table rendering - #430
Closed
AdamMagued wants to merge 1 commit into
Closed
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
When rendering a table configured with AutoMerge and empty/zero visible columns or when columns are suppressed, reBalanceMaxMergedColumnLengths previously divided by numMergedColumns or columnsRemaining without checking for zero, causing an integer divide by zero runtime panic. Guard rebalancing by returning early when numColumns or maxColumnLengths is empty, and verify divisor positive bounds. Add regression tests in TestTable_Render_AutoMerge_EdgeCases. Fixes jedib0t#426
|
Author
|
Closing in favor of earlier community PR #427 to keep the review queue clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rendering a table configured with AutoMerge and empty/zero visible columns or when columns are suppressed, reBalanceMaxMergedColumnLengths previously divided by numMergedColumns or columnsRemaining without checking for zero, causing an integer divide by zero runtime panic.
Guard rebalancing by returning early when numColumns or maxColumnLengths is empty, and verify divisor positive bounds. Add regression tests in TestTable_Render_AutoMerge_EdgeCases.
Fixes #426