Skip to content

fix(api): preserve Jellyfin single album songs - #2422

Merged
jeffvli merged 1 commit into
jeffvli:developmentfrom
atirna:fix/jellyfin-single-album-songs
Sep 22, 2026
Merged

jeffvli merged 1 commit into
jeffvli:developmentfrom
atirna:fix/jellyfin-single-album-songs

Conversation

@atirna

@atirna atirna commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Preserves the songs returned for a Jellyfin album detail request.

Problem

The stale AlbumId filter removes tracks from some singles even though the request is already scoped by ParentId.

Fix

Pass the parent-scoped response to album normalization unchanged.

Fixes #2076

Testing

  • pnpm lint:staged
  • pnpm typecheck

@vercel

vercel Bot commented Sep 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
feishin Ready Ready Preview Sep 5, 2026 6:18am UTC

@jeffvli

jeffvli commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Can you confirm that the bug noted in the comment for the lines you changed is fixed on Jellyfin?

Because if you remove those lines, that will reintroduce a different bug.

@atirna

atirna commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor Author

the comment's bug was about the old query, not this one.

the filter (d9da588, #2041) covered AlbumIds: query.id, which Jellyfin matches by id or album name (the getSongList bodge documents the same), so same-named releases leaked. bf501da then switched this request to ParentId: query.id for #2111: descendants of the album item only, no name matching. since then the filter could only drop songs ParentId legitimately returns: the #2076 singles have the album as parent, but their AlbumId field points at their own single entry.

nothing needed fixing jellyfin-side, the workaround was for a parameter this request stopped using in august.

@jeffvli
jeffvli merged commit 0bfc111 into jeffvli:development Sep 22, 2026
8 checks passed
@atirna
atirna deleted the fix/jellyfin-single-album-songs branch September 22, 2026 06:11

This branch was successfully deployed

1 active deployment
Preview — aff63ebe Deployed Sep 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Singles can't be played nor does not appear in UI

2 participants