Skip to content

fix: proper icon sizing in drawables #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeiel85 merged 2 commits into from
Aug 15, 2026
Merged

fix: proper icon sizing in drawables #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64c5e40
fix: proper icon sizing in drawables
ThatOneCalculator Aug 14, 2026
745b5cd
fix(icon): keep the vein weight, and drop the unrelated debug suffix
jeiel85 Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 32 additions & 14 deletions app/src/main/res/drawable/ic_launcher_foreground.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,35 @@
<?xml version="1.0" encoding="utf-8"?>
<!--
Adaptive-icon foreground. The 512 viewport is the source artwork; the group
scales it to 0.85 and re-centres it (translate = 256 * (1 - 0.85)) so the leaf
stays inside the 66dp safe circle instead of being clipped by the launcher
mask (#318). It used to reach 34dp from centre against a 33dp safe radius;
it now reaches 28.9dp.

Stroke width is the original 2.5dp scaled by the same 512/108 factor as the
geometry (2.5 x 4.7407), so the '#' veins keep the weight they have in
`ic_launcher_monochrome.xml`. Scaling the geometry without it leaves the two
layers drawing the same mark at different weights.
-->
<vector xmlns:android="http://schemas.android.com/apk/res/android"
android:width="108dp"
android:height="108dp"
android:viewportWidth="108"
android:viewportHeight="108">
<!-- 나뭇잎 형태 (Markleaf 정체성) -->
<path
android:fillColor="#2E7D32"
android:pathData="M54,20 C54,20 30,35 30,60 C30,85 54,88 54,88 C54,88 78,85 78,60 C78,35 54,20 54,20 Z" />
<!-- 마크다운 '#' 기호를 형상화한 나뭇잎 맥 -->
<path
android:strokeColor="#FFFFFF"
android:strokeWidth="2.5"
android:strokeLineCap="round"
android:pathData="M54,35 L54,75 M45,45 L63,45 M45,55 L63,55" />
android:width="512dp"
android:height="512dp"
android:viewportWidth="512"
android:viewportHeight="512">
<group
android:translateX="38.4"
android:translateY="38.4"
android:scaleX="0.85"
android:scaleY="0.85">
<!-- 나뭇잎 형태 (Markleaf 정체성) -->
<path
android:fillColor="#2E7D32"
android:pathData="M 256 94.815 C 256 94.815 142.222 165.926 142.222 284.444 C 142.222 402.963 256 417.185 256 417.185 C 256 417.185 369.778 402.963 369.778 284.444 C 369.778 165.926 256 94.815 256 94.815 Z" />
<!-- 마크다운 '#' 기호를 형상화한 나뭇잎 맥 -->
<path
android:strokeColor="#FFFFFF"
android:strokeWidth="11.852"
android:strokeLineCap="round"
android:pathData="M 256 165.926 L 256 355.556 M 213.333 213.333 L 298.667 213.333 M 213.333 260.741 L 298.667 260.741" />
</group>
</vector>
34 changes: 23 additions & 11 deletions app/src/main/res/drawable/ic_launcher_monochrome.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,29 @@
single-color silhouette. We keep the Markleaf leaf and cut the markdown '#'
veins out as negative space (fillType=evenOdd) so the identity survives tinting
instead of collapsing into a featureless blob.

Geometry mirrors `ic_launcher_foreground.xml`: same 512 viewport, same 0.85
group scale that keeps the leaf inside the 66dp safe circle (#318). Keep the
two files in step. The launcher draws whichever layer the user's theme asks
for, so a divergence shows up as the icon changing shape when themed icons
are turned on.
-->
<vector xmlns:android="http://schemas.android.com/apk/res/android"
android:width="108dp"
android:height="108dp"
android:viewportWidth="108"
android:viewportHeight="108">
<path
android:fillColor="#000000"
android:fillType="evenOdd"
android:pathData="M54,20 C54,20 30,35 30,60 C30,85 54,88 54,88 C54,88 78,85 78,60 C78,35 54,20 54,20 Z
M52.75,35 L55.25,35 L55.25,75 L52.75,75 Z
M45,43.75 L63,43.75 L63,46.25 L45,46.25 Z
M45,53.75 L63,53.75 L63,56.25 L45,56.25 Z" />
android:width="512dp"
android:height="512dp"
android:viewportWidth="512"
android:viewportHeight="512">
<group
android:translateX="38.4"
android:translateY="38.4"
android:scaleX="0.85"
android:scaleY="0.85">
<path
android:fillColor="#000000"
android:fillType="evenOdd"
android:pathData="M 256 94.815 C 256 94.815 142.222 165.926 142.222 284.444 C 142.222 402.963 256 417.185 256 417.185 C 256 417.185 369.778 402.963 369.778 284.444 C 369.778 165.926 256 94.815 256 94.815 Z
M 250.074 165.926 L 261.926 165.926 L 261.926 355.556 L 250.074 355.556 Z
M 213.333 207.407 L 298.667 207.407 L 298.667 219.259 L 213.333 219.259 Z
M 213.333 254.815 L 298.667 254.815 L 298.667 266.667 L 213.333 266.667 Z" />
</group>
</vector>