docs: credit the launcher-icon fix in THANKS - #320
Merged
Merged
Conversation
#318 is the first outside patch that is not a translation, so the section's framing needed widening: the point it makes about translations -- that they are the contribution the maintainer cannot check -- has a sibling, which is the bug the maintainer has stopped seeing. The icon had been clipped by the adaptive-icon mask since it was drawn, on my own home screen, for months. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds @ThatOneCalculator to the Contributed table for #318, and fixes one gap found while auditing the file.
The section's opening was written around translations, which are the contribution
I cannot verify myself. #318 is the first outside patch that isn't one, and it
belongs to a different category worth naming: the bug the maintainer has stopped
seeing. The leaf had been running past the adaptive-icon safe zone since the icon
was drawn, so every launcher clipped its tip, and it sat on my own home screen for
months without registering.
While in there I checked the Reported table against every externally-filed issue.
One was missing: @ElizabethWega reported #298,
which was fixed in #299 and #300, and only their earlier #283 was listed. Added.
The other 17 reporters were all accounted for, and no Discussions thread has an
outside author yet.
🤖 Generated with Claude Code