Have optional subcommands take priority over positional arguments#299
Open
peterebden wants to merge 2 commits intojessevdk:mainfrom
Open
Have optional subcommands take priority over positional arguments#299peterebden wants to merge 2 commits intojessevdk:mainfrom
peterebden wants to merge 2 commits intojessevdk:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As illustrated in the test case, if there's an optional subcommand but the parent command also takes positional arguments, the subcommand is never selected. This PR alters the order of checks so it is preferred over filling in a positional argument.
I suppose this probably represents a slightly suboptimal flag design in the first place since it implies some ambiguity, but we found ourselves there nonetheless :(