Add an interface for flag types that can provide default values#422
Open
peterebden wants to merge 3 commits intojessevdk:mainfrom
Open
Add an interface for flag types that can provide default values#422peterebden wants to merge 3 commits intojessevdk:mainfrom
peterebden wants to merge 3 commits intojessevdk:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple use case might be that you want a flag to have the value of
os.UserCacheDir()and don't want to replicate its logic and/or deal with per-platform structs.I suppose there's a chance that someone already has a type with this method signature which suddenly starts providing defaults. I think the chance is probably low, but there's no real way of avoiding that with Go's implicit interfaces.
Fixes #421