Conversation
There was a problem hiding this comment.
Pull request overview
Updates Propulsion’s DynamoStore/Lambda toolchain to align with Equinox.DynamoStore 4.2 (rc) and the AWS SDK v4 package stack, including required adjustments to Lambda event handling and minimum FSharp.Core requirements.
Changes:
- Bump AWS SDK package references to v4 across tool + Lambda projects, and update Lambda event parsing to match newer event model types.
- Upgrade
Equinox.DynamoStoreto4.2.0-rc.1. - Pin
PropulsiontoFSharp.Core8.x (with associated cleanup in tests).
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Propulsion.Tool/Propulsion.Tool.fsproj | Updates AWS SDK dependencies (STS/SSO) to v4 for the CLI tool. |
| tools/Propulsion.Tool/Infrastructure.fs | Refactors indentation/top-level declarations for Cosmos connector helpers/extensions. |
| tests/Propulsion.Tests/Propulsion.Tests.fsproj | Removes explicit FSharp.Core pin from tests project. |
| src/Propulsion/Propulsion.fsproj | Pins FSharp.Core to 8.0.403 to support struct DU + RequireQualifiedAccess with newer compilers. |
| src/Propulsion/Pipeline.fs | Adjusts indentation of SourcePipeline type (offside rule/scoping). |
| src/Propulsion.DynamoStore/Propulsion.DynamoStore.fsproj | Upgrades Equinox.DynamoStore to 4.2.0-rc.1. |
| src/Propulsion.DynamoStore.Notifier/Propulsion.DynamoStore.Notifier.fsproj | Updates Lambda + AWS SDK dependencies; adds DynamoDBStreams SDK reference. |
| src/Propulsion.DynamoStore.Notifier/Handler.fs | Updates parsing logic to use newer DynamoDBEvent field types (strings vs enums). |
| src/Propulsion.DynamoStore.Indexer/Propulsion.DynamoStore.Indexer.fsproj | Updates Lambda package references to newer versions. |
| src/Propulsion.DynamoStore.Indexer/Handler.fs | Updates DynamoDBEvent parsing for new event field shapes/types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/Propulsion.DynamoStore.Notifier/Propulsion.DynamoStore.Notifier.fsproj
Outdated
Show resolved
Hide resolved
f49c2d1 to
32bd09c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggered by jet/equinox#480
@njlr Have not pushed to nuget as yet; could push
-previewpackages as and when you or others are making use of Propulsion.DynamoStore with the v$ AWSSDK stack