Scope product-lifecycle and update-advisor eval prompts - #1
Merged
jhadvig merged 1 commit intoJul 9, 2026
Conversation
Both eval system prompts were identical copies of a broad "OpenShift upgrade advisor" persona. This made it impossible to isolate what each eval was actually testing. - product-lifecycle: narrow to single-skill prompt focused on the Product Life Cycle API (mirrors find-token/kubernetes-docs pattern) - update-advisor: rewrite with its own identity and decision matrix - test_cases: decouple queries from CVO proposal framing so they exercise the product-lifecycle skill directly - Remove dangling OWNERS symlink from product-lifecycle eval Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Product lifecycle manual test exercise - All tests pass 🔍 Click to expand - Product Lifecycle Test Log🔍 Click to expand - Product Lifecycle Sandbox container logs |
Collaborator
Author
|
All Update Adivisory evals tests pass 🔍 Click to expand - Update Advisory Test Log🔍 Click to expand - Update Advisory Sandbox container logs |
Collaborator
Author
|
This changes should address failures on eval exeuctions of openshift#34 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Both eval system prompts were character-for-character identical. This made it impossible to isolate what each eval was testing — a product-lifecycle failure could have been caused by the broad persona routing through another skill. Each eval should test one thing.
Test plan
🤖 Generated with Claude Code