Repository navigation
Train 26: #596, #581 - #602
Merged
Merged
Conversation
…ve toxml (0233) The five C++-only filters were registered but rendered an empty string. Per docs/release-2.0.md D16, camelize(upper_first=true), underscorize, escapecpp and toyaml now render the output docs/cpp-only-filters.md describes; toxml is removed and is an unknown filter, as in Jinja2. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017KNXpdwgCcK4gqUkYrVXzK
…t long keys (0233) Found by the verifier: a lead byte followed by 32 or more continuation bytes shifted 0x7F past 31 bits in toyaml and tojson. Keys over 255 bytes are written as explicit '? key' entries, since YAML limits an implicit key to 1024 characters. The doc now says undefined values raise, as they do. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017KNXpdwgCcK4gqUkYrVXzK
Value can now hold an integer outside int64: jinja2::BigInt keeps its canonical decimal text (TryParse, Sign, ToInt64/ToUInt64, comparisons by value). The integral constructor, Reflect and the three JSON bindings store a BigInt for a value above INT64_MAX instead of throwing std::overflow_error (0172). sizeof(Value) is unchanged (40 B). Value gains IsBigInt, AsBigInt and the pointer form; ToString, ToChars and std::formatter print the digits. Until 0270 a BigInt that enters a template fails the render with std::overflow_error. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLuNcuiZnzXVsxhZ3MzE9V
…til 0270 Addresses the verifier's MSVC risk (C4244/C4296 on narrow integral types under /W4 /WX) and documents that ToString prints a BigInt only at top level until templates hold big integers.
…ad-7n5o77 # Conflicts: # docs/tasks/0233-cpp-only-filter-stubs.md
A defaulted move could leave the string empty, and Sign() then read front() of an empty string. The move operations now leave the source "0", so every BigInt holds a canonical number. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VLuNcuiZnzXVsxhZ3MzE9V
Found by Codex: a host generator with no end grew the serialized text without bound. Both writers now check the text against MaxSequenceSize per item. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017KNXpdwgCcK4gqUkYrVXzK
Regenerate the task index and parity table. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DTQTriEsFrrBgcYNKDUUF4
|
To use Codex here, create an environment for this repo. |
rmorozov
marked this pull request as ready for review
October 19, 2026 02:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration train, one CI run (master 3985100, after train 25).
Stacked: #596 (0269 public BigInt, head 65cec3e), #581 (0233 C++-only filters, head 267fb39).
Resolved here: #596 against the Markup alternatives from train 25 (
BigIntis appended afterWMarkupinValue::ValueData, includes forfwd.handbig_int.hboth kept, docs row). Regenerated the task index and the parity table (1939 templates), set 0269 to done. No task number duplicates. ctest 3/3 locally.Codex: both have a result and no unanswered P0/P1 (#596: P2 fixed in 65cec3e, re-review clean; #581: P1 fixed, P2 declined with reason).
@codex security reviewnever started on #596. Owners' own CI was green on both heads.Roles: steward only.
Generated by Claude Code