git: reject remote names invalid in fetch refspecs#9334
Closed
lawrence3699 wants to merge 1 commit into
Closed
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
|
Can you please move the PR description into the commit message to adhere to our style, thanks. |
Contributor
|
Dup of #9155? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9099
jj git remote addcurrently panics if the symbolic remote name can't be used in the generated fetch refspec.For example,
jj git remote add 'this also fails' https://github.com/jj-vcs/jj.gitaborts withReferenceName(InvalidByte { byte: " " })instead of returning a user-facing error.This validates symbolic remote names with
gix::remote::name::validated()before writing the remote config, so invalid names fail cleanly instead of panicking.I also added CLI coverage for empty, whitespace-containing, and whitespace-only remote names.
Validation:
cargo test -q -p jj-cli --test runner test_git_remoteChecklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)how it works, how it's organized), including any code drafted by an LLM.
an eye towards deleting anything that is irrelevant, clarifying anything
that is confusing, and adding details that are relevant. This includes,
for example, commit descriptions, PR descriptions, and code comments.