Open
Conversation
fullykubed
suggested changes
Aug 20, 2025
fullykubed
left a comment
fullykubed
left a comment
There was a problem hiding this comment.
Only use typescript or bash for scripting. no js
fullykubed
suggested changes
Aug 20, 2025
fullykubed
left a comment
fullykubed
left a comment
There was a problem hiding this comment.
I cant tell if the new markdown content is just placeholder or not but it has tons of errors so I am just assuming it was for testing purposes. I'd like to confirm though.
fullykubed
suggested changes
Aug 20, 2025
| <label for="module-search" class="block text-sm font-medium text-primary"> | ||
| Search Modules | ||
| </label> | ||
| <input |
There was a problem hiding this comment.
interactive elements must use kobalte. see styleguide
|
|
||
| // Filter modules based on search and filters | ||
| const filteredModules = createMemo(() => { | ||
| return props.modules.filter(module => { |
There was a problem hiding this comment.
needs to do fuzzy and relevancy search
| return type.charAt(0).toUpperCase() + type.slice(1); | ||
| } | ||
|
|
||
| function formatGroupTitle(group: string): string { |
There was a problem hiding this comment.
same as above. would rather have a static mapping with a fallback.
this fails for aws
| })); | ||
| } | ||
|
|
||
| function formatTypeTitle(type: string): string { |
There was a problem hiding this comment.
id rather just have a static mapping with this as a fallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current State:
aws_vpcas an example. Has some example docs with both flat and nested folder structuresStill TODO:
Questions: