Skip to content

docs: document PR-body templates and the config auto-upgrade pass - #586

Merged
jlong merged 1 commit into
mainfrom
jlong/docs-document-pr-body-templates-and-config-auto-upgrade
Aug 25, 2026
Merged

jlong merged 1 commit into
mainfrom
jlong/docs-document-pr-body-templates-and-config-auto-upgrade

Conversation

@jlong

@jlong jlong commented Aug 25, 2026

Copy link
Copy Markdown
Owner

Task

Two v0.9.0 features shipped without user-facing docs on the site. Document both, verified against the source.

1. Worker-authored PR bodies from a per-project template (#581)

Workers now author PR descriptions from an editable per-project template rather than a hardcoded body. Read the source before writing:

  • crates/shelbi-state/src/pr_template.rs (rendering + variable substitution)
  • crates/shelbi-state/src/default_pr_template.md.template (the shipped default body)
  • The per-project override file (confirm its on-disk name/location from the code, e.g. a pr-template.md under the project dir).

Document, in site/content/docs/configuration/ (extend project.mdx near the existing branch-template docs, or add a focused section):

  • What the template is, the shipped default, and where a per-project override lives.
  • The placeholders/variables available for substitution (verify the exact set from pr_template.rs).
  • How a worker uses it to author the PR body at handoff.

2. Config auto-upgrade sniffer (#550, #552, #572)

A version-agnostic validate-and-upgrade pass runs on boot: it detects drifted/legacy config, auto-heals what it safely can, and hands needs-judgment findings to the orchestrator. Read the source (config_upgrade.rs and the findings JSON structure) before writing.

Document, in site/content/docs/configuration/ or concepts/:

  • What it does on boot: detect → classify (auto_heal vs needs_judgment) → apply.
  • What the user sees: auto-healed changes, and needs-judgment findings surfaced to the orchestrator.
  • Any user-inspectable artifact (e.g. the config-upgrade-findings.json file — confirm the real name/path from code).

Technical Details

Verify every path, variable name, file name, and behavior against the actual source and the CLI. Do not invent flags, paths, or placeholders — depictions of Shelbi behavior must match the code exactly.

Acceptance Criteria

  • The PR-body template feature is documented under configuration/: template location(s) (shipped default + per-project override), the available variables, and how workers use it at handoff.
  • The config auto-upgrade pass is documented (boot-time detect → classify → auto-heal vs needs-judgment handoff) including any user-inspectable artifact.
  • All file paths, variable names, and behaviors are verified against the actual source (pr_template.rs, default_pr_template.md.template, config_upgrade.rs), not invented.
  • Avoid unnecessary em dashes in the new prose. "Shelbi" is capitalized in prose.
  • The site builds cleanly: npm run build in site/ succeeds with no MDX errors.

Auto-opened by Shelbi — review at: /Users/jlong/.shelbi/projects/shelbi/tasks/docs-document-pr-body-templates-and-config-auto-upgrade.md

Two v0.9.0 features shipped without site docs. Document both, verified
against source.

- configuration/project.mdx: add a "PR-body template (pr-template.md)"
  section covering the config-mode-aware location (shipped default +
  per-project override), the five default sections, and how a worker
  authors .shelbi/pr-body.md at handoff. Corrected the task's premise:
  pr_template.rs does NO variable substitution, so the section documents
  it as prose instructions and explicitly contrasts it with the
  {{var}}-substituting git.branch template.

- concepts/config-upgrade.mdx (new, order 18): document the boot-time
  detect -> classify (auto_heal vs needs_judgment) -> apply pass, the
  events.log disclosure line, the ~/.shelbi/config-upgrade-findings.json
  artifact, and the orchestrator needs-judgment handoff.

- cli/config.mdx: document the previously-undocumented `upgrade`
  subcommand and its flags (--all, --apply, --needs-judgment,
  --apply-finding, --format), the inspection surface for the pass.

All paths, variable/file names, flags, and the events.log body verified
against pr_template.rs, default_pr_template.md.template, config_upgrade.rs,
config.rs, serve.rs, and reload.rs. Cross-link anchor verified against the
built heading id. Site builds and lints clean; no em dashes in new prose.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercel Bot commented Aug 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
shelbi Ready Ready Preview Aug 25, 2026 3:46pm

Request Review

@jlong
jlong merged commit 006df93 into main Aug 25, 2026
3 checks passed
@jlong
jlong deleted the jlong/docs-document-pr-body-templates-and-config-auto-upgrade branch August 25, 2026 15:47

This branch was successfully deployed

1 active deployment
Preview — 8419d96a Deployed Aug 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant