Repository navigation
FIX FlexiBLAS CI default backend and scope script hang - #296
Merged
Merged
Conversation
…pe observation script Co-authored-by: Cursor <cursoragent@cursor.com>
ogrisel
marked this pull request as ready for review
November 5, 2026 08:01
ogrisel
marked this pull request as draft
November 5, 2026 08:01
ogrisel
marked this pull request as ready for review
November 5, 2026 09:08
ogrisel
commented
Nov 5, 2026
ogrisel
left a comment
Contributor
Author
There was a problem hiding this comment.
LGTM, I will merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the FlexiBLAS CI jobs, which started failing on
masterafter an upstream FlexiBLAS change. Found while investigating the failures in #294 (#294).Root cause
024e3c19cand28cf5ba3e, Nov 3 2026) made the default backend a CMake option namedFLEXIBLAS_DEFAULT_BLAS.continuous_integration/install_flexiblas.shstill passed-DFLEXIBLAS_DEFAULT=OPENBLAS_CONDA, which is now silently ignored. FlexiBLAS falls back toNETLIB, sotest_flexiblasandtest_flexiblas_switchfail on Linux.tests/empirical_scope_observation.py,run()starts a non-daemon thread that counts threads and only stops it when the BLAS/OpenMP probe returns normally. If the probe raises (on macOS, numpy's import-time sanity check failed under theNETLIBdefault), the thread keeps the interpreter alive and the job hangs until the 30 minute timeout.Changes
-DFLEXIBLAS_DEFAULT_BLAS="OPENBLAS_CONDA".default = OPENBLAS_CONDA, so a future silent fallback breaks the build immediately.finallyblock so an exception in the probe cannot hang the process.Evidence
fa70d83, and FIX recursive wrap, plus controlling thread cleanups and doc improvements #294 atb57a863): Linux FlexiBLAS reportsDefault BLAS: NETLIBand fails the two tests. macOS hangs. The nightlymasterschedule failed the same jobs on Nov 5.3224de8): all 26 checks pass. Both FlexiBLAS jobs reportDefault BLAS: OPENBLAS_CONDAandcurrent_backend: OPENBLAS_CONDA.Open questions
NETLIBbackend is not investigated here. It does not affect the setup onceOPENBLAS_CONDAis the default.masterbranch. Pinning a release tag would avoid this kind of breakage, at the cost of catching upstream regressions later.