This repository was archived by the owner on May 7, 2021. It is now read-only.
Configurable Guru Timeout#951
Open
robbawebba wants to merge 1 commit into
Open
Conversation
d97a3d5 to
50d2875
Compare
50d2875 to
5ecd342
Compare
Collaborator
|
Looks like a couple tests are broken, but otherwise LGTM. |
Author
|
Hi @zmb3, thanks for taking a look! Have you seen this before while running tests locally? |
Collaborator
|
I haven't seen that locally, though I admit it's been a while since I've tried. That sounds to me like a gopath or working directory problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a user-configurable timeout value to all guru commands.
closes #951
Two concerns I would like to address about the proposed changes:
guru: no initial packages were loaded. I'm unsure if this is due to my local dev environment, so I wanted to see if the tests pass in the CI environment.