markus/bazelDecoupleBazelTooling#6082
Closed
ml86 wants to merge 2 commits into
Closed
Conversation
ml86
commented
Jul 7, 2026
ml86
commented
Contributor
- [bazel] Decouple Joern and bazel_tooling module versions.
- [bazel] Add common runtime deps to further rule macros.
This became nessessary because the codepropertygraph repo depends on bazel_tooling and Joern depends on codepropertygraph.
We also add such a flag to scala_binary, java_binary and java_test to be able to enforce certain runtime deps on a per module basis. As a way to avoid the default a ignore_common_runtime_deps attribute was introduced.
maltek
reviewed
Jul 7, 2026
maltek
left a comment
maltek
left a comment
Contributor
There was a problem hiding this comment.
Referencing files from the same repo, but in an old revision is too much for me. I don't like this at all.
What problem does this solve, and is there any other way to solve it?
Contributor
Author
|
Fair point. I will move it into flatgraph which is at the root of our repo dependency tree. That way we avoid this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.