fix(ui): use new quantity field across components - #1
Closed
cmatzenbach wants to merge 5 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
stats-quantitiesbranch introduces a quantity field onOperatorStatisticand rescales duration values from nanoseconds to seconds on the backend before sending them to the UI. Without corresponding FE changes, all_nsduration statistics display incorrect values - the existinginferFieldFormattertreated the value as nanoseconds, but it's now receiving seconds, causing values to be off.This wires the quantity field through to every display site so values are formatted using the
QuantitySpecfromQueryBundle.quantity_specsrather than name-based heuristics.Display sites updated:
formatStatWithQuantity, receivingquantity_specsas a new prop from QueryPlanformatStatWithQuantityformatQuantitydirectly when a resolvedQuantitySpecis availableformatStatValue/formatNumericStataccept an optionalQuantitySpec; the operator table computes astatQuantitySpecsmap from quantity_specs and threads it through to the table cellsRelated Issues
Relates to PR rapidsai#471
Testing