Update protobuf-java to 4.34.1#2360
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the protobuf-java dependency to version 4.34.1. However, the protobuf-java-util dependency was left at version 3.25.9. Feedback suggests updating both to the same version to avoid binary incompatibility and potential runtime errors caused by mixing major versions of Protobuf.
| lazy val paiges = Def.setting("org.typelevel" %%% "paiges-core" % "0.4.4") | ||
| lazy val protobufJava = | ||
| Def.setting("com.google.protobuf" % "protobuf-java" % "3.25.9") | ||
| Def.setting("com.google.protobuf" % "protobuf-java" % "4.34.1") |
There was a problem hiding this comment.
The update to protobuf-java 4.34.1 is incomplete. The dependency protobuf-java-util on line 32 is still using version 3.25.9. Mixing major versions of Protobuf (4.x and 3.x) is not supported and will likely lead to runtime errors such as NoSuchMethodError due to binary incompatibilities. As noted in the PR description, this file still refers to the old version number; please update protobuf-java-util to 4.34.1 to maintain consistency.
References
- When updating library versions, ensure that all related libraries are updated to the same version to prevent potential binary compatibility issues or runtime errors.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2360 +/- ##
==========================================
+ Coverage 85.00% 85.01% +0.01%
==========================================
Files 197 197
Lines 49254 49254
Branches 12214 12214
==========================================
+ Hits 41867 41874 +7
+ Misses 7387 7380 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Superseded by |
About this PR
📦 Updates com.google.protobuf:protobuf-java from
3.25.9to4.34.1⚠Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
🔍 Files still referring to the old version number
The following files still refer to the old version number (3.25.9).
You might want to review and update them manually.
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: