refactor: delete stale app surfaces#262
Conversation
Remove dead dependency declarations, disabled magic-auth endpoints, the duplicate source attachment module, legacy extract text payload support, stale frontend storage migration, and the single-provider LLM adapter seam. The previous code kept compatibility and abstraction surfaces that no longer had a live product path. This keeps the app's proof boundary smaller without adding new behavior. Verified with doctor, pyrefly, mypy, targeted pytest/e2e groups, full non-e2e pytest, and scripts/check-coverage.sh at 100% diff coverage.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d13fecf125
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return {"path": "extract", "text": req.text} | ||
|
|
||
| # New shape: name is mandatory | ||
| name = (req.name or "").strip() |
There was a problem hiding this comment.
Text-only requests now fall through to missing_concept here because the legacy branch was removed, but scripts/b9-python-smoke.py still documents and executes scenario 3 as POST /api/extract with only {"text": ...} and expects HTTP 200. That repo-owned smoke command will now report a failure even when extraction is healthy; update/delete that scenario or keep compatibility until the smoke is migrated.
Useful? React with 👍 / 👎.
Remove dead dependency declarations, disabled magic-auth endpoints, the duplicate source attachment module, legacy extract text payload support, stale frontend storage migration, and the single-provider LLM adapter seam. The previous code kept compatibility and abstraction surfaces that no longer had a live product path. This keeps the app's proof boundary smaller without adding new behavior. Verified with doctor, pyrefly, mypy, targeted pytest/e2e groups, full non-e2e pytest, and scripts/check-coverage.sh at 100% diff coverage.
1 participant
Context & Intent
.supergoal/ROADMAP.md.Implementation Details
/api/extracttext payload support, stale frontend storage migration, and the one-provider LLM adapter seam.drill_statusfallbacks and direct Gemini drill/repair paths.scripts/agent-push.pyso first pushes of newfeat/*branches work through the repo-owned authorization wrapper.MVP / Deployment Risk Check
UX Framework Alignment (For UI/Drill changes)
Verification:
bash scripts/doctor.sh.venv/bin/pyrefly check.venv/bin/mypy ..venv/bin/pytest -q --ignore=tests/e2ebash scripts/check-coverage.sh— 100% diff coveragetests/test_agent_push.py -q— 27 passed