Flash and segmentation features added#24
Flash and segmentation features added#24rotexdegba wants to merge 19 commits intojosantonius:mainfrom
Conversation
rotexdegba
commented
Oct 26, 2024
- Moved exception methods into the new trait \Josantonius\Session\ExceptionThrowingMethodsTrait
- Added a new Exception (\Josantonius\Session\Exceptions\EmptySegmentNameException) used in the new Session Segment class (\Josantonius\Session\FlashableSessionSegment)
- Added a new Session Segment Class (\Josantonius\Session\FlashableSessionSegment) that stores data in a sub-array inside $_SESSION & provides data flashing functionality
- Added a new Interface (\Josantonius\Session\SessionInterface)
- Josantonius\Session\Session changes:
- Now implements \Josantonius\Session\SessionInterface
- start method now sets the session name before starting the session if the name option is specified
- Exception throwing method have been moved to \Josantonius\Session\ExceptionThrowingMethodsTrait
- Uses \Josantonius\Session\ExceptionThrowingMethodsTrait to make exception throwing methods available
- Added tests to test all features in \Josantonius\Session\FlashableSessionSegment
- Updated README.md with instructions on how to use \Josantonius\Session\FlashableSessionSegment
…on methods have been moved to ExceptionThrowingMethodsTrait & start method now calls session_name if a name option was passed in the options array
…Josantonius\Session\FlashableSessionSegment
|
Please let me know if you have any questions about this pull request. |
|
Thank you for the PR! I’ll review it thoroughly when I have a bit more time, as there’s quite a lot to go through. |
You are welcome. Let me know if you need explanation on anything in the pull request. I realize that the documentation I added was a bit wordy, maybe we could tighten it up after you merge the pull request. Thanks |
|
Thank you very much for your contribution to the Session library and for the effort you've put into enhancing its functionality. After reviewing the changes, I have come to the conclusion that the primary goal of this library is to encapsulate session handling in an object-oriented way. While the The other proposed changes, which are not related to If you decide to create a separate library for the Again, thank you for your valuable contribution. I appreciate your understanding and look forward to possibly collaborating in the future. |
Thanks for the reply. I will create a fork of this project that contains the |