Log full Throwable on Q2 start failure#743
Merged
Merged
Conversation
Q2's main loop caught Throwable and logged only t.getMessage(), which turns diagnosable failures into one-line riddles. A missing BouncyCastle jar on the runtime classpath, for instance, showed up as just 'org/bouncycastle/bcpg/ArmoredInputStream' with no stack trace and no hint that PGPHelper linking was the site of the failure. Every other catch block in Q2 logs the Throwable itself; do the same here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Q2's main loop caughtThrowableand logged onlyt.getMessage(), which turns diagnosable failures into one-line riddles.Real case that prompted this: a user running with BouncyCastle missing from the runtime classpath got only
No stack trace, no indication that the failure was
logVersion()→PGPHelper.getLicense()failing to link, and no way to tell a missing jar from an API break. Every othercatchblock inQ2logs theThrowableitself; this one now does too.🤖 Generated with Claude Code