Repository navigation
reject non-finite cost values in json parser - #113
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
- Coverage 85.01% 84.88% -0.13%
==========================================
Files 1 1
Lines 2329 2336 +7
==========================================
+ Hits 1980 1983 +3
- Misses 349 353 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
|
Makes sense. Thanks. |
Contributor
Author
|
Thanks for taking this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A JSON profile whose cost is
NaNorInfinityreaches this, since json.load accepts those tokens as an extension even though schema.json defines costs as finite numbers. The non-finite value lands in the per-function and global SAMPLES totals, so one crafted event poisons the denominator of every ratio (other functions collapse to 0%) and NaN then propagates into color() and aborts the run. Reject the tokens with a parse_constant callback so the profile is refused at load instead.