Skip to content

various fixes to modeling#1459

Merged
z3dev merged 13 commits into
V3from
fixes-part-3
Jun 20, 2026
Merged

various fixes to modeling#1459
z3dev merged 13 commits into
V3from
fixes-part-3

Conversation

@z3dev

@z3dev z3dev commented May 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

These changes contain various fixes to modeling, including:

  • allow appendArc, appendBezier, appendPoints to closed paths
  • corrected snap of path2 and path3 when closed
  • small performance changes from refactor(modeling)!: no geometry clone #1201
  • changed extrudeLinearGeom2 to use pre-allocated mat4 and vec3
  • lots of small changes for consistency based on lint reports (and a few bugs fixes)

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

z3dev added 13 commits May 30, 2026 15:27
@z3dev
feat(modeling): allow appendArc, appendBezier, appendPoints to closed…
fc0ca2c 
… paths
@z3dev
fix(modeling): corrected snap of path2 and path3 when closed
578466d
@z3dev
docs(modeling): changes from reviews
76132a4
@z3dev
fix(modeling): small fix to parameter checks
b26cf6e
@z3dev
perf(modeling): small performace changes
1104518
@z3dev
fix(modeling): corrected close, reverse, and transform functions in g…
d738828 
…eometries
@z3dev
perf(modeling): changed extrudeLinearGeom2 to use preallocated mat4 a…
c742491 
…nd vec3
@z3dev
build(all): changed linting to use eslint directly
8d70047
@z3dev
style(all): changes based on lint
d277fbf
@z3dev
style(all): small fixes for consistent return values
9028132
@z3dev
style(all): changes for consistent default case statements
8b87c79
@z3dev
style(all): changes for consistent assignment statements
c10ae23
@z3dev
style(all): changes for consistent blocks
0145caa
@z3dev z3dev requested review from danmarshall, hrgdavor, mister-jscad and platypii and removed request for danmarshall June 14, 2026 07:00
mister-jscad
mister-jscad approved these changes Jun 20, 2026
View reviewed changes

@mister-jscad mister-jscad left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@z3dev z3dev merged commit 9443688 into V3 Jun 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mister-jscad mister-jscad mister-jscad approved these changes

@platypii platypii Awaiting requested review from platypii

@hrgdavor hrgdavor Awaiting requested review from hrgdavor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@z3dev @mister-jscad