Skip to content

Document storage adapter boundary - #11

Merged
juliosuas merged 1 commit into
mainfrom
fsociaty/storage-adapter-boundary
Jul 8, 2026
Merged

Document storage adapter boundary#11
juliosuas merged 1 commit into
mainfrom
fsociaty/storage-adapter-boundary

Conversation

@juliosuas

Copy link
Copy Markdown
Owner

What changed

  • Documents the storage adapter contract required before Ghost can advertise non-SQLite backends.
  • Makes ghost doctor respect a config override for unsupported DATABASE_URL schemes instead of checking the global default.
  • Adds a regression test proving a PostgreSQL override reports a hard database error until a real adapter exists.
  • Updates issue 👻 Welcome to Ghost — Getting Started & Feature Requests #1 response proof from 56 to 57 passing tests.

Why

Ghost is the highest-star personal repo right now. The strongest reputation move is making the storage roadmap precise, test-backed, and honest for security/OSINT users.

Proof

  • .venv/bin/python -m pytest -q — 57 passed
  • .venv/bin/ruff check .
  • .venv/bin/ruff format --check .
  • .venv/bin/ghost doctor --json — ok, 0 errors, 0 warnings
  • git diff --check
  • Screenshots or terminal output added/updated when user-facing behavior changed

Safety

  • This supports authorized security research, journalism, law enforcement, or self-audits
  • No private target data, secrets, generated databases, reports, or investigation artifacts are committed
  • New collection behavior is documented and scoped

Define the non-SQLite storage contract, make doctor respect database URL overrides, and add a regression test for unsupported PostgreSQL configuration.
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@juliosuas, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 39776760-3065-43eb-8735-6df086eb4969

📥 Commits

Reviewing files that changed from the base of the PR and between 7620bb6 and f357a91.

📒 Files selected for processing (7)
  • README.md
  • V2_PLAN.md
  • docs/issue-1-response.md
  • docs/storage-adapter-boundary.md
  • ghost/backend/db.py
  • ghost/core/doctor.py
  • tests/test_investigator.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fsociaty/storage-adapter-boundary

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@juliosuas
juliosuas merged commit b1792a3 into main Jul 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant