fix: [plugin] correct CSS variable name from primaryText to primary-text#892
Open
silvercondor wants to merge 1 commit intojup-ag:mainfrom
Open
fix: [plugin] correct CSS variable name from primaryText to primary-text#892silvercondor wants to merge 1 commit intojup-ag:mainfrom
silvercondor wants to merge 1 commit intojup-ag:mainfrom
Conversation
The customization docs used --jupiter-plugin-primaryText (camelCase) but the compiled plugin CSS uses --jupiter-plugin-primary-text (kebab-case), so the documented override had no effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Plugin customization docs listed
--jupiter-plugin-primaryText(camelCase) in the CSS theme example, but the compiled plugin CSS atplugin.jup.aguses--jupiter-plugin-primary-text(kebab-case). Setting the camelCase variable has no effect — verified by setting it to0, 0, 0(no change) vs the kebab-case version (text turns black).Changes
tool-kits/plugin/customization.mdx: rename--jupiter-plugin-primaryText→--jupiter-plugin-primary-textin the CSS theme example