Add handling for asymmetric TSP#59
Open
mikedbjones wants to merge 4 commits into
Open
Conversation
merge updates from jvkersch/pyconcorde main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #28 , I've made the following changes to handle asymmetric TSP (for example real-world driving/walking problems).
symmetricize()function in util.py.is_symmetricboolean property ofProblem, so that asymmetric problems can be tracked through to the solution, which necessarily needs to be modified (removing ghost nodes that were added insymmetricize()).remove_ghost_nodes()method to Solutionraise ValueErrorwhen a non-integer matrix is passed (Concorde provides solution of 0 with float matrices)So far as I'm aware, this code does not break any existing functionality with symmetric matrices, nor other problem solutions.
If you're happy with the changes I've made, I'm happy to explain more in the readme and create another PR.
Thanks!