fix: improve battery health accuracy (use FccComp1 over raw capacity) - #8
Merged
Conversation
Owner
|
@wChenonly appreciate your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously battery health was calculated using AppleRawMaxCapacity / DesignCapacity,
which reflects raw hardware capacity and results in a lower value (~79%).
However, macOS reports battery health based on a calibrated capacity value.
The correct field is BatteryData.FccComp1, which represents the compensated
full charge capacity and aligns with system-reported health (~83%).
This change updates the calculation to prefer FccComp1 when available,
with a fallback to AppleRawMaxCapacity for compatibility.