Repository navigation
Docs: describe Stop and the run thread as the code implements them - #34
Merged
Merged
Conversation
`docs/architecture.md` and AGENTS.md still said the Scheme run executes on `Dispatchers.IO` and that an abandoned run keeps running there. Since issue #11's fix, `SchemeRunner` runs each program on its own single-thread daemon executor precisely so a runaway abandoned by Stop cannot occupy the shared IO pool; the KDoc on `EditorViewModel.stopRun()` and `SchemeRunner` already say so. Bring the diagram, the run-flow step and the Stop paragraph in line, spell out the cost (the thread and a core stay busy until the program ends), and point at #24 for the real fix. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Baiju Muthukadan <baiju.m.mail@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-only. Salvaged from an uncommitted draft left in the PR #22 worktree, plus the same correction applied to the sentences around it.
docs/architecture.mdandAGENTS.mdstill said the Scheme run executes onDispatchers.IOand that a run abandoned by Stop keeps running there. Since #11's fix,SchemeRunnerruns each program on its own single-thread daemon executor precisely so a runaway cannot occupy the shared IO pool — the KDoc onEditorViewModel.stopRun()andSchemeRunner.runExecutoralready describe this.Changes:
architecture.md: dedicated executor, the cost of an abandoned infinite loop (thread + core busy until it ends), why it cannot starve other work, and a pointer to Stop: move Scheme execution into an isolated process so runaway programs can actually be killed #24 for the real fix.architecture.md, and the Android execution-model bullet inAGENTS.md, no longer sayDispatchers.IO.No code changes. #24 should update this paragraph again when the isolated-process runner lands.
🤖 Generated with Claude Code