Conversation
There was a problem hiding this comment.
Pull request overview
This pull request introduces a Go-based implementation of the Agent Development Kit (ADK) for Kagent, enabling declarative agent images with support for Azure OpenAI and Anthropic models. The implementation maintains parity with the existing Python-based ADK while providing a native Go alternative.
Changes:
- Adds comprehensive Go ADK implementation in
go-adk/directory with core utilities, skills management, and LLM model adapters - Introduces CRD schema updates to support custom image overrides via
spec.imagefield - Implements build infrastructure for the Go ADK container image (
app-go)
Reviewed changes
Copilot reviewed 59 out of 61 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
go-adk/pkg/core/*.go |
Core package with shared types, session management, task storage, event conversion, and HITL utilities |
go-adk/pkg/adk/*.go |
ADK integration layer for Google ADK compatibility, event conversion, and config loading |
go-adk/pkg/adk/models/*.go |
LLM model implementations for OpenAI, Azure OpenAI, and Anthropic |
go-adk/pkg/skills/*.go |
Skills discovery and shell execution utilities for file operations and command execution |
go-adk/Dockerfile |
Multi-stage build for Go ADK container image |
go-adk/Makefile |
Build and test automation for Go modules |
Makefile |
Root Makefile updates for building app-go image with proxy support |
helm/kagent-crds/templates/kagent.dev_agents.yaml |
CRD updates adding image field with documentation |
go/config/crd/bases/kagent.dev_agents.yaml |
CRD base updates for image override support |
go/api/v1alpha2/agent_types.go |
Go API types updated with Image field for deployment spec |
go/internal/controller/translator/agent/adk_api_translator.go |
Controller logic to use custom image when specified |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hey @yanivmn, this PR is really coming together. I think I have 3 main comments remaining.
|
Signed-off-by: Yaniv Marom Nachumi <yanivmar@amdocs.com>
Signed-off-by: Yaniv Marom Nachumi <yanivmar@amdocs.com>
Signed-off-by: Yaniv Marom Nachumi <yanivmar@amdocs.com>
Signed-off-by: Yaniv Marom Nachumi <yanivmar@amdocs.com>
Signed-off-by: Yaniv Marom Nachumi <yanivmar@amdocs.com>
Signed-off-by: Yaniv Marom Nachumi <yanivmar@amdocs.com>
Signed-off-by: Yaniv Marom Nachumi <yanivmar@amdocs.com>
Signed-off-by: Yaniv Marom Nachumi <yanivmar@amdocs.com>
Signed-off-by: Yaniv Marom Nachumi <yanivmar@amdocs.com>
Signed-off-by: Yaniv Marom Nachumi <yanivmar@amdocs.com>
Signed-off-by: Yaniv Marom Nachumi <yanivmar@amdocs.com>
I see a lot of changes have been made, but I don't see either of these questions really answered. |
|
Hi, i didnt had the time for it yet. |
go-adk directory maintained separately until community approval.
Tested AzureOpenIA and Anthropic Models.