feat: add pod annotations by muffl0n · Pull Request #3449 · kanisterio/kanister

muffl0n · 2025-04-23T07:22:30Z

Change Overview

Allow annotations to be set in Helm chart

Pull request type

Please check the type of change your PR introduces:

Issues

fixes Allow annotations to be set in Helm chart #3443

Test Plan

💪 Manual
⚡ Unit test
💚 E2E

viveksinghggits · 2025-04-23T10:55:11Z

Hi @muffl0n,
Thank you for the PR. Do you mind adding some unit tests here https://github.com/kanisterio/kanister/blob/master/pkg/testing/helm/helm_test.go

Maybe we should just install (--dry-run) kanister with some annotations provided (using values.yaml) and make sure that they are present in the rendered deployment resource manifest.

muffl0n · 2025-04-23T14:08:41Z

I remember playing around with the helm tests some month ago and realising too late, that it does things on the current configured k8s context. Is this still the case? Is there some documentation that describes what it does and what prerequisite are needed?

Testing the templates alone feels more like a use case for something like https://github.com/helm-unittest/helm-unittest cause installing the resources is not really needed here. 🤔

Signed-off-by: Sven Schliesing <muffl0n@raffts.net>

viveksinghggits · 2025-04-23T15:31:32Z

I remember playing around with the helm tests some month ago and realising too late, that it does things on the current configured k8s context. Is this still the case? Is there some documentation that describes what it does and what prerequisite are needed?

Testing the templates alone feels more like a use case for something like https://github.com/helm-unittest/helm-unittest cause installing the resources is not really needed here. 🤔

So in our github actions we use kind cluster and then try to just run helm install with --dry-run flag.
Or in other words from our github actions (https://github.com/kanisterio/kanister/blob/master/.github/workflows/main.yaml#L90) we call make helm-test which eventually calls ./build/helm-test.sh. That runs the test in https://github.com/kanisterio/kanister/blob/master/pkg/testing/helm/helm_test.go against the kind cluster.

@muffl0n if you want someone from us can push the test on top of this PR.

muffl0n · 2025-04-28T12:08:44Z

if you want someone from us can push the test on top of this PR.

That would be awesome! Unfortunately, some deadlines are blocking me from investing more time into this. :(

viveksinghggits · 2025-04-28T12:53:23Z

if you want someone from us can push the test on top of this PR.

That would be awesome! Unfortunately, some deadlines are blocking me from investing more time into this. :(

no problem @muffl0n , I will ask someone else to continue working on this PR.

a-kumar5 · 2025-05-10T05:51:30Z

@viveksinghggits Can i work upon this PR to add the helm tests?

hairyhum · 2025-05-27T19:06:05Z

@a-kumar5 sure, go ahead. Thanks.

a-kumar5 · 2025-05-28T07:27:06Z

@viveksinghggits @hairyhum Raised a new PR: #3491 Please review the changes and let me know.

github-actions · 2025-08-27T00:14:30Z