Repository navigation
feat(helm): add imagePullSecrets support to kanister-operator chart - #4192
Open
FrancescoCastaldi wants to merge 1 commit into
Open
FrancescoCastaldi wants to merge 1 commit into
FrancescoCastaldi wants to merge 1 commit into
Conversation
Resolves kanisterio#2999 Allow users to configure imagePullSecrets on the kanister-operator Deployment via the Helm chart. This is required in air-gapped environments where images are pulled from private registries that require authentication. Changes: - Add imagePullSecrets: [] field to values.yaml with example comments - Render imagePullSecrets in deployment.yaml when the list is non-empty - Add TestImagePullSecretsFromHelmChart test covering single secret, multiple secrets, and default (empty/absent) cases Signed-off-by: FrancescoCastaldi <francescocastaldi@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2999
Allow users to configure imagePullSecrets on the kanister-operator Deployment via the Helm chart values.
Problem
In air-gapped environments or clusters that use private container registries with authentication, the operator pod fails to pull the controller image because there was no way to pass imagePullSecrets through the Helm chart.
Solution
Usage
\\yaml
values.yaml
imagePullSecrets:
\
or via CLI:
\\�ash
helm install kanister kanister/kanister-operator
--set 'imagePullSecrets[0].name=my-registry-secret'
\\
Testing
Validated with \helm lint --strict\ and \helm template\ — chart passes with 0 failures.