Repository navigation
end2end tests: identify Chrome to Wikipedia and fix visited marks checks - #539
Merged
Merged
Conversation
Since October 2026 Wikipedia intermittently responds to headless Chrome on CI with `429 Too many requests` (Firefox isn't affected), so `test_show_visited_marks` couldn't find the links on the page. Append an identifying suffix to Chrome's user agent as per https://meta.wikimedia.org/wiki/User-Agent_policy, since compliant user agents are supposed to get more lenient rate limits. In `test_show_visited_marks`, wait for all indexed links to acquire `promnesia-visited` (the old condition waited for marks to be absent), and check that no other links on the page get marked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since October 2026 Wikipedia intermittently responds to headless Chrome on CI with
429 Too many requests(Firefox isn't affected), sotest_show_visited_markscouldn't find the links on the page. Append an identifying suffix to Chrome's user agent as per https://meta.wikimedia.org/wiki/User-Agent_policy, since compliant user agents are supposed to get more lenient rate limits.In
test_show_visited_marks, wait for all indexed links to acquirepromnesia-visited(the old condition waited for marks to be absent), and check that no other links on the page get marked.