Support conversions on NonZero<T>#36
Draft
dhardy wants to merge 2 commits into
Draft
Conversation
dhardy
force-pushed
the
push-xrkuqkruyoor
branch
2 times, most recently
from
f5b0805 to
b50b341
Compare
This was referenced Nov 19, 2025
dhardy
force-pushed
the
push-xrkuqkruyoor
branch
from
b50b341 to
530e11d
Compare
dhardy
force-pushed
the
push-xrkuqkruyoor
branch
from
eb41afb to
d78d11d
Compare
Contributor
Author
|
Rebased over #39. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof-of-concept: supporting conversions on
NonZero<T>whereT: ZeroablePrimitiveshouldn't be hard...... but without being able to use trait
ZeroablePrimitivethis will have to be re-written using a macro and quite a lot of impls.Fixes #33.