Support appending/replacing text (parts) to a TextDisplay#140
Merged
Conversation
Contributor
Author
|
The motivation for this didn't quite work out for text editors since highlighting information also needs to be updated piecemeal, then matched up to the One (minor) feature is needed now: the ability to turn off I will merge this PR anyway because (in my opinion) it fits well into kas-text and may eventually find some other uses. API change summaryNew pub methods on
Changed pub methods on
New pub struct
New pub struct
New pub struct
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds lower-level methods for adding text to a
TextDisplay, supporting adding a text in parts. Also supports replacing text parts.Motivation
The existing design is a poor fit for text editors and potentially also for viewing large documents for performance reasons: it requires (re)-preparing all text at once.
This new API supports splitting a source text at line-breaks and adding each part independently, appending to or replacing old content.
Currently text-wrapping and alignment must still happen for all content afterwards; this could be addressed in the future (if necessary) but is relatively cheap.