declare strict_types in all files

.php-cs-fixer.dist.php

@@ -14,6 +14,7 @@
         '@PER-CS3x0' => true,
         '@PER-CS3x0:risky' => true,
         '@PHPUnit100Migration:risky' => true,
+        'declare_strict_types' => true,
         'linebreak_after_opening_tag' => true,
         'ordered_imports' => true,
         'no_empty_phpdoc' => true,

src/Redmine/Api.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine;
 
 /**

src/Redmine/Api/AbstractApi.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use InvalidArgumentException;

src/Redmine/Api/Attachment.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;

src/Redmine/Api/CustomField.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;
@@ -149,7 +151,7 @@ public function listing($forceUpdate = false, array $params = [])
     {
         @trigger_error('`' . __METHOD__ . '()` is deprecated since v2.7.0, use `' . self::class . '::listNames()` instead.', E_USER_DEPRECATED);
 
-        return $this->doListing($forceUpdate, $params);
+        return $this->doListing((bool) $forceUpdate, $params);
     }
 
     /**

src/Redmine/Api/Group.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;

src/Redmine/Api/Issue.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;

src/Redmine/Api/IssueCategory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;
@@ -175,7 +177,7 @@ public function listing($project, $forceUpdate = false)
     {
         @trigger_error('`' . __METHOD__ . '()` is deprecated since v2.7.0, use `' . self::class . '::listNamesByProject()` instead.', E_USER_DEPRECATED);
 
-        return $this->doListing($project, $forceUpdate);
+        return $this->doListing($project, (bool) $forceUpdate);
     }
 
     /**

src/Redmine/Api/IssuePriority.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;

src/Redmine/Api/IssueRelation.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;

src/Redmine/Api/IssueStatus.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;
@@ -148,7 +150,7 @@ public function listing($forceUpdate = false)
     {
         @trigger_error('`' . __METHOD__ . '()` is deprecated since v2.7.0, use `' . self::class . '::listNames()` instead.', E_USER_DEPRECATED);
 
-        return $this->doListing($forceUpdate);
+        return $this->doListing((bool) $forceUpdate);
     }
 
     /**

src/Redmine/Api/Membership.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;

src/Redmine/Api/News.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;

src/Redmine/Api/Project.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use InvalidArgumentException;
@@ -170,7 +172,7 @@ public function listing($forceUpdate = false, $reverse = true, array $params = [
     {
         @trigger_error('`' . __METHOD__ . '()` is deprecated since v2.7.0, use `' . self::class . '::listNames()` instead.', E_USER_DEPRECATED);
 
-        return $this->doListing($forceUpdate, $reverse, $params);
+        return $this->doListing((bool) $forceUpdate, $reverse, $params);
     }
 
     /**

src/Redmine/Api/Query.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;

src/Redmine/Api/Role.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;

src/Redmine/Api/Search.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;

src/Redmine/Api/TimeEntry.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;

src/Redmine/Api/TimeEntryActivity.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;

src/Redmine/Api/Tracker.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;
@@ -147,7 +149,7 @@ public function listing($forceUpdate = false)
     {
         @trigger_error('`' . __METHOD__ . '()` is deprecated since v2.7.0, use `' . self::class . '::listNames()` instead.', E_USER_DEPRECATED);
 
-        return $this->doListing($forceUpdate);
+        return $this->doListing((bool) $forceUpdate);
     }
 
     /**

src/Redmine/Api/User.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;
@@ -168,7 +170,7 @@ public function listing($forceUpdate = false, array $params = [])
     {
         @trigger_error('`' . __METHOD__ . '()` is deprecated since v2.7.0, use `' . self::class . '::listLogins()` instead.', E_USER_DEPRECATED);
 
-        return $this->doListing($forceUpdate, $params);
+        return $this->doListing((bool) $forceUpdate, $params);
     }
 
     /**

src/Redmine/Api/Version.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;
@@ -177,7 +179,7 @@ public function listing($project, $forceUpdate = false, $reverse = true, array $
     {
         @trigger_error('`' . __METHOD__ . '()` is deprecated since v2.7.0, use `' . self::class . '::listNamesByProject()` instead.', E_USER_DEPRECATED);
 
-        return $this->doListing($project, $forceUpdate, $reverse, $params);
+        return $this->doListing($project, (bool) $forceUpdate, $reverse, $params);
     }
 
     /**

src/Redmine/Api/Wiki.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Api;
 
 use Redmine\Client\Client;

src/Redmine/Client/Client.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Client;
 
 use Redmine\Api;

src/Redmine/Client/ClientApiTrait.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Client;
 
 use Redmine\Api;

src/Redmine/Exception.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine;
 
 use Throwable;

src/Redmine/Exception/ClientException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Exception;
 
 use Exception;

src/Redmine/Exception/InvalidApiNameException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Exception;
 
 use InvalidArgumentException;

src/Redmine/Exception/InvalidParameterException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Exception;
 
 use InvalidArgumentException;

src/Redmine/Exception/MissingParameterException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Exception;
 
 use InvalidArgumentException;

src/Redmine/Exception/SerializerException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Exception;
 
 use Redmine\Exception as RedmineException;

src/Redmine/Serializer/JsonSerializer.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Serializer;
 
 use JsonException;

src/Redmine/Serializer/PathSerializer.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Serializer;
 
 use Stringable;

src/Redmine/Serializer/XmlSerializer.php

@@ -1,12 +1,14 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Serializer;
 
+use Exception;
 use JsonException;
 use Redmine\Exception\SerializerException;
 use SimpleXMLElement;
 use Stringable;
-use Throwable;
 
 /**
  * XmlSerializer.
@@ -75,7 +77,7 @@ private function deserialize(string $encoded): void
 
         try {
             $this->deserialized = new SimpleXMLElement($encoded);
-        } catch (Throwable $e) {
+        } catch (Exception $e) {
             $errors = [];
             $code = $e->getCode();
 
@@ -123,8 +125,8 @@ private function denormalize(array $normalized): void
         $prevSetting = libxml_use_internal_errors(true);
 
         try {
-            $this->deserialized = $this->createXmlElement($rootElementName, $this->normalized[$rootElementName]);
-        } catch (Throwable $e) {
+            $this->deserialized = $this->createXmlElement((string) $rootElementName, $this->normalized[$rootElementName]);
+        } catch (Exception $e) {
             $errors = [];
 
             foreach (libxml_get_errors() as $error) {
@@ -196,7 +198,7 @@ private function addChildToXmlElement(SimpleXMLElement $xml, $k, $v): void
             $array = $xml->addChild($k, '');
             $array->addAttribute('type', 'array');
             foreach ($v as $id) {
-                $array->addChild($specialParams[$k], $id);
+                $array->addChild($specialParams[$k], (string) $id);
             }
         } elseif (is_array($v)) {
             $array = $xml->addChild($k, '');
@@ -231,7 +233,7 @@ private function attachCustomFieldXML(SimpleXMLElement $xml, array $fields, stri
                 $_field->addAttribute('field_format', $field['field_format']);
             }
             if (isset($field['id'])) {
-                $_field->addAttribute('id', $field['id']);
+                $_field->addAttribute('id', strval($field['id']));
             }
             if (array_key_exists('value', $field) && is_array($field['value'])) {
                 $_field->addAttribute('multiple', 'true');
@@ -243,7 +245,7 @@ private function attachCustomFieldXML(SimpleXMLElement $xml, array $fields, stri
                 } else {
                     $_values->addAttribute('type', 'array');
                     foreach ($field['value'] as $val) {
-                        $_values->addChild('value', $val);
+                        $_values->addChild('value', (string) $val);
                     }
                 }
             } else {

tests/Unit/Api/AbstractApiTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Redmine\Tests\Unit\Api;
 
 use InvalidArgumentException;