fix: bundle DigiCert CA certs instead of downloading during Docker build#208
Closed
fix: bundle DigiCert CA certs instead of downloading during Docker build#208
Conversation
Co-Authored-By: Jakub Sochan <jakub.sochan@keboola.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docker build fails at Dockerfile line 133 with
curl: (60) SSL: no alternative certificate subject name matches target host name 'cacerts.digicert.com'. Thephp:7.4-clibase image has an outdated CA bundle that can't verify DigiCert's current server certificate.Fix: bundle the two DigiCert CA certificate files (
GeoTrustRSACA2018.crt,DigiCertGlobalRootCA.crt) indocker/andCOPYthem into the image instead of downloading at build time. This also makes the build more reproducible by removing the external download dependency.Certificates were downloaded from the official DigiCert URLs and verified:
7C:CC:2A:87:E3:94:9F:20:57:2B:18:48:29:80:50:5F:A9:0C:AC:3B(expires 2027)A8:98:5D:3A:65:E5:E5:C4:B2:D7:D6:6D:40:C6:DD:2F:B1:9C:54:36(expires 2031)Review & Testing Checklist for Human
Notes