fix: track modified_instances when removing an interface#448
Open
keepsimple1 wants to merge 1 commit intomainfrom
Open
fix: track modified_instances when removing an interface#448keepsimple1 wants to merge 1 commit intomainfrom
keepsimple1 wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #447
Problem
When a network interface was removed,
remove_records_on_intfonly tracked instances whose PTR records were fully gone (i.e. no remaining PTR on any interface). Instances that still had a PTR record but lost address or other records on the removed interface were silently ignored — their cachedServiceInfobecame stale without any notification to listeners.Changes
remove_records_on_intfto return bothremoved_instancesandmodified_instances.resolve_updated_instancesformodified_instancesafter interface removal, triggering a newServiceResolvedevent with the updated (reduced) address set.