Add Windows snapshots and forks - #433
Open
sjmiller609 wants to merge 23 commits into
Open
Conversation
sjmiller609
force-pushed
the
hypeship/windows-snapshots
branch
3 times, most recently
from
August 20, 2026 14:14
ddd1d35 to
7886185
Compare
sjmiller609
force-pushed
the
hypeship/windows-snapshots
branch
from
August 20, 2026 19:26
7886185 to
2723b54
Compare
sjmiller609
force-pushed
the
hypeship/windows-snapshots
branch
2 times, most recently
from
August 20, 2026 23:41
19ab53d to
ec253b0
Compare
sjmiller609
force-pushed
the
hypeship/windows-snapshots
branch
from
August 21, 2026 00:13
ec253b0 to
8c18bc9
Compare
sjmiller609
marked this pull request as ready for review
August 25, 2026 20:48
sjmiller609
force-pushed
the
hypeship/windows-snapshots
branch
from
August 25, 2026 22:03
8c18bc9 to
7df3857
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 09ce3d1. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

summary
bitlocker=disabledtargeted tests
Both dedicated Windows KVM gates and the full Linux, Darwin, and install suites pass. The final head also passed six consecutive full workflow runs without a hidden Windows-gate retry (runs 33095320830, 33096527026, 33097202925, 33100760941, 33104170468, and 33105225214).
Note
High Risk
Changes core Windows VM lifecycle (TPM, VioSock, fork/restore concurrency, and guest identity) and removes prior hard blocks on snapshot operations, so regressions could cause identity collisions or unsafe forks on BitLocker-protected images.
Overview
Windows standby, restore, snapshots, and forks are enabled end-to-end on QEMU, replacing the previous blanket rejection of snapshot lifecycle on
windows/amd64. Same-instance standby/restore keeps disk, NVRAM, TPM, and memory together; forks split identity by path—stopped forks clear TPM, assign a new VioSock CID, and cold-boot; memory/standby forks keep captured TPM, VioSock, and NIC state until the child cold-starts, with serialized restore (windowsRestoreMu) and checks so two VMs cannot share a captured CID concurrently. Running sources requiretarget_state=Stoppedfor forks; running standby snapshot forks need the source stopped first.Fork admission requires image label
io.hypeman.machine-image.bitlocker=disabled(parsed on create intoWindowsBitLockerPolicy). After fork,RebindIdentityon the guest agent sets a newMachineGuidand records the instance ID; the manager calls it on start/restore whenWindowsIdentityPendingis set.Guest API: new
RebindIdentityRPC (proto, client helper with retries, Windows agent implementation).CI: shared
run-windows-integration-test.sh(isolatedTMPDIR, QEMU/swtpm cleanup, retries) drives lifecycle, stopped-fork, and hypervisor gates; workflow cleanup includesswtpmand Windows test temp dirs. Integration coverage shifts from the old networking-heavy test toTestWindowsLifecycleIntegrationandTestWindowsStoppedForkIntegration.Docs: BitLocker label on Windows images; new
docs/windows-snapshots.md; instances README section on fork identity. Minor test-harness fix: bridge names derived from subnet and safer stale route cleanup.Reviewed by Cursor Bugbot for commit 5d22773. Bugbot is set up for automated code reviews on this repo. Configure here.