fix: rename cache key for tree details builds to avoid key collision#1849
Open
gustavobtflores wants to merge 1 commit intokernelci:mainfrom
Open
fix: rename cache key for tree details builds to avoid key collision#1849gustavobtflores wants to merge 1 commit intokernelci:mainfrom
gustavobtflores wants to merge 1 commit intokernelci:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a cache key collision between
get_tree_details_buildsandget_tree_data(data_type="builds"). Both functions used the identical cache key "treeDetailsBuilds", causing the summary endpoint to populate the cache with dict rows. When the builds endpoint subsequently accessed that cache,get_tree_datatried to read those dicts as tuples via positional indexingrow[0], triggeringKeyError: 0.Changes
get_tree_details_buildscache key from "treeDetailsBuilds" to "treeDetailsBuildsDirect" to avoid collision withget_tree_data