Skip to content

feat: improve icon layout in Section using float-based positioning #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dede999 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

feat: improve icon layout in Section using float-based positioning #1852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions dashboard/src/components/Section/Section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,14 +128,18 @@ const Section = ({
<div className="text-dim-gray mb-6 flex flex-col gap-4">
<div className="flex flex-col gap-2">
{eyebrow && <span className="text-sm">{eyebrow}</span>}
<div className="flex flex-row items-center gap-2">
{leftIcon}
<div className="overflow-hidden">
{leftIcon && (
<span className="float-left mr-2 -mb-2 [&_svg]:h-8 [&_svg]:w-8">
{leftIcon}
</span>
)}
{rightIcon && <span>{rightIcon}</span>}
Copy link
Copy Markdown
Collaborator

@MarceloRobert MarceloRobert Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the rightIcon should be reverted to its place

Image

{title && (
<span className="max-w-full text-2xl font-bold break-all">
{title}
</span>
)}
{rightIcon}
</div>
{subtitle}
</div>
Expand Down
Loading