Add tests for 2N methods#71
Open
chrisba23 wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks! However, the purpose of this code is not clear to me. The basic package already automatically checks the order of accuracy after it finds a method. |
Owner
|
Oh, sorry -- I see now that this adds these checks to the automated test suite. Running these manually, I see that most of them run fairly fast and seem to always pass. But these do involve randomness, and the (8,4) search in particular often fails. I'm not sure how I feel about having tests that sometimes fail under the current code. |
Contributor
|
Good point. Failing checks involving randomness is problematic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds basic 2N tests for several stage/order combinations and checks the order conditions.