Skip to content

Implement dividerHeight and dividerThickness#52

Open
jenow wants to merge 3 commits into
kfiross:masterfrom
jenow:master
Open

Implement dividerHeight and dividerThickness#52
jenow wants to merge 3 commits into
kfiross:masterfrom
jenow:master

Conversation

@jenow

@jenow jenow commented Aug 10, 2022

Copy link
Copy Markdown

What does this PR do?

Implement dividerHeight and dividerThickness to change the size of dividers.

Usage

DatePicker.showSimpleDatePicker(
  context,
  initialDate: DateTime(1994),
  firstDate: DateTime(1960),
  dateFormat: "dd-MMMM-yyyy",
  dividerHeight: 1.0,
  dividerThickness: 1.0,
);

Hyla96
Hyla96 suggested changes Feb 16, 2023
View reviewed changes
Comment thread lib/date_picker.dart
_selectedDate = date;
}),
looping: looping,
dividerHeight: dividerHeight,

@Hyla96 Hyla96 Feb 16, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to move this to the theme instead, (Since the dividerColor is passed there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Hyla96 Hyla96 Hyla96 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jenow @Hyla96